completions #131

crpb · 2025-04-12T21:50:35Z

My Maintainer is to lazy so here goes..

https://salsa.debian.org/debian/zsh/-/merge_requests/8#note_604077

* fix: apt-config shell options + add missing options * new: satisy, autoremove, autpurge, --allow-downgrades, --allow-remove-essential,--allow-change-held-packages, --with-new-pkgs, indextargets, --snapshot/-S * snapshot lookup via mr/timestamp * edit-sources file lookup for .list & .sources

* update bts backends from `reportbug --bts help` output

* added -raw-extract/-R, --ctrl-tarfile, --verify/-V, --clear-selections, --predep-package, --assert

* added --url/-u, --noconf, --version * extended --component by non-free-firmware

* fixed: --extra-package * changed behaviour to allow options multiple times for --extra-package, --dpkg-source-opt[s]

* added --all-source-chroots, --exclude-aliases, --shell/-s --option/-o, --automatic-session, --session-name/-n * extend shell lookup via /etc/shells

* updated archs (source: popcon)

* add opt -D (.dsc)

* remove "--delete"

* complete databases

* console should only work with running machines * add guestinfo to fast opts (w/o --domain)

* add PROGRESS2 to --info

* add json option+arguments * update devicetypes arguments

* added refreservation to delegatable permissions * fixed scriptname completion to only list filenames

* add eventtype "button"

last seen in squeeze

complete _deb_packages aval

* NEW (complies to latest upstream version) https://salsa.debian.org/debian/debian-goodies/-/commit/1f9a8a771ba68e791ceb7c4821fbdaac78f4921b

* complete _deb_packages avail

_apt: * fix: apt-config shell options + add missing options * new: satisy, autoremove, autpurge, --allow-downgrades, --allow-remove-essential,--allow-change-held-packages, --with-new-pkgs, indextargets, --snapshot/-S * snapshot lookup via mr/timestamp * edit-sources file lookup for .list & .sources _apt-file: add list-indices _bug: update bts backends from `reportbug --bts help` output _deb_architectures: update archs (source: popcon) _deb_files: add opt -D (.dsc) _debmany: complete _deb_packages aval _debsnap: complete _deb_packages avail _dhomepage: * NEW (complies to latest upstream version) https://salsa.debian.org/debian/debian-goodies/-/commit/1f9a8a771ba68e791ceb7c4821fbdaac78f4921b _dpkg: add missing options * add -raw-extract/-R, --ctrl-tarfile, --verify/-V, --clear-selections, --predep-package, --assert _dpkg-info: complete _deb_packages avail _fortune: complete databases _libvirt: * console should only work with running machines * add guestinfo to fast opts (w/o --domain) _losetup: remove "--delete" _madison: add missing options * add --url/-u, --noconf, --version * extend --component by non-free-firmware * add url-shorthand for table "all" _rsync: * add PROGRESS2 to --info _sbuild: * fix: --extra-package * change behaviour to allow options multiple times for --extra-package, --dpkg-source-opt[s] _schroot: * add --all-source-chroots, --exclude-aliases, --shell/-s, --option/-o, --automatic-session, --session-name/-n * extend shell lookup via /etc/shells _smartmontools: * add json option+arguments * update devicetypes arguments _wanna-build: remove (last seen in squeeze) _which-pkg-broke: complete _deb_packages avail _x_utils: add eventtype "button" _zfs: * added refreservation to delegatable permissions * fixed scriptname completion to only list filenames

general: adjust wording for consistency, conventional mood and capitalisation _apt: - improve _apt_sources(). simplify apt-config calls. add fall-back paths. don't create global sources array - rename _snapshotdates() to _apt_snapshot_dates. eliminate superfluous getdates() function. use $commands instead of whence. eliminate superfluous variable _fortune: use _files to complete databases _smartmontools: fix -j/--json exclusivity, --json optarg style _schroot: fix -n/-o optargs, short option optarg styles

general: adjust wording for consistency, conventional mood and capitalisation _apt: - improve _apt_sources(). simplify apt-config calls. add fall-back paths. don't create global sources array - rename _snapshotdates() to _apt_snapshot_dates. eliminate superfluous getdates() function. use $commands instead of whence. eliminate superfluous variable. show date format _fortune: use _files to complete databases _smartmontools: fix -j/--json exclusivity, --json optarg style _schroot: fix -n/-o optargs, short option optarg styles

the previous implementation fetched all of the individual snapshot date+times but then stripped off the times, leaving only the last 6 months' worth of dates. if that's all we're going to complete, we can simply generate the dates locally ofc this function could be significantly more elaborate, conditionally fetch based on $PREFIX$SUFFIX, etc

okdana · 2025-05-04T12:08:32Z

(sorry if those references caused spam)

i found a few issues/inconsistencies. most are trivial but the _apt ones are more problematic

my suggested fixes: https://github.com/crpb/zsh/compare/cb/completions..okdana:zsh:dana/cb-completions

the entire change set (since that doesn't show the actual commits i guess): crpb/zsh@cb/completions...okdana:zsh:dana/cb-completions

lmk if you object to anything there, otherwise i'll merge those along with your changes

given the size of the pr and the fact that we're getting close to release i might wait until after 5.10 unless someone feels otherwise

crpb · 2025-05-04T15:10:42Z

hey @okdana ,

on the use of eval i have to laugh as i used that first and then @ft said i should not do it :p.
anyhow, thanks for taking the time and improving it as i'm more guessing what i do their than anything else but wanted most of those changes finally be not only in my $fpath :p.

given the size of the pr and the fact that we're getting close to release i might wait until after 5.10 unless someone feels otherwise

it would benefit the soon to be debian stable zsh release :-).
@mika 👋🏼

okdana · 2025-05-04T15:39:32Z

on the use of eval i have to laugh as i used that first and then @\ft said i should not do it :p

sorry, it did occur to me that it might've been a deliberate choice. if there were objections to it i can put it back

it would benefit the soon to be debian stable zsh release :-). @\mika 👋🏼

isn't it too late for 5.10 to go into trixie?

make optional, remove unnecessary exclusions

crpb · 2025-05-04T15:57:12Z

sorry, it did occur to me that it might've been a deliberate choice. if there were objections to it i can put it back

leave it, there are more of them in the completion :P.

isn't it too late for 5.10 to go into trixie?

no idea, but he should be able to say as the packager

mika · 2025-05-04T16:26:16Z

on the use of eval i have to laugh as i used that first and then @\ft said i should not do it :p

sorry, it did occur to me that it might've been a deliberate choice. if there were objections to it i can put it back

it would benefit the soon to be debian stable zsh release :-). @\mika 👋🏼

isn't it too late for 5.10 to go into trixie?

We're currently in the soft freeze stage (see https://release.debian.org/testing/freeze_policy.html#soft) and 11 days before hard-freeze (2025-05-15). I don't know how large and instrusive the changes between 5.9 and 5.10 will actually be, but given that last stable release v5.9 dates back 2022-05-14 (AKA ~3 years), AFAICS that will be quite something ™️ overall. I'd assume zsh 5.10 also wouldn't show up within the very next few days, nor? 🤔

So from my current PoV we probably won't see zsh 5.10 with trixie. :-/

okdana · 2025-05-04T16:43:45Z

it's in the testing phase, so it's possible it gets released before hard freeze. but yeah it will have some major changes so even if policy allowed it i'd hesitate to suggest putting it in this late

mika · 2025-05-04T16:56:20Z

it's in the testing phase,

Good to hear, looking forward!

so it's possible it gets released before hard freeze. but yeah it will have some major changes so even if policy allowed it i'd hesitate to suggest putting it in this late

ACK, thanks!

crpb · 2025-05-16T07:41:12Z

@okdana
today i realized that the completion with e.g. apt-get source isn't implemented at all for only source packages. i tinkered a bit with it but would kindly ask if you could add that aswell because the logic of retrieving those was alreadty added 9 years ago but never used in _apt as it seems.
What i'm talking about is compdef '_deb_packages source' moo.
So the commands like apt[-get] (source|build-dep) apt-se<TAB> should complete apt-setup which is a source-package from the installer and not usable in any other way(like install/..) afaik.

I got the completion working with _apt-cmd but in that _apt-get i'm again struggling so i thought this would be easier this way 🙈 🙊 🙉

general: adjust wording for consistency, conventional mood and capitalisation _apt: - improve _apt_sources(). simplify apt-config calls. add fall-back paths. don't create global sources array - rename _snapshotdates() to _apt_snapshot_dates. eliminate superfluous getdates() function. use $commands instead of whence. eliminate superfluous variable. show date format _fortune: use _files to complete databases _smartmontools: fix -j/--json exclusivity, --json optarg style _schroot: fix -n/-o optargs, short option optarg styles

the previous implementation fetched all of the individual snapshot date+times but then stripped off the times, leaving only the last 6 months' worth of dates. if that's all we're going to complete, we can simply generate the dates locally ofc this function could be significantly more elaborate, conditionally fetch based on $PREFIX$SUFFIX, etc

make optional, remove unnecessary exclusions

okdana · 2025-05-16T20:11:55Z

@crpb i looked at it briefly. it should be as simple as having source and build-dep make two calls to _deb_packages with _alternative. we could also account for --only-source if we wanted to be complete

idk what the clean/idiomatic way to do that with _regex_arguments is though. tbh i can't stand it and i don't want to learn. rather than just copy+paste everything i'll have to let someone more knowledgeable figure out how to structure/format it

crpb · 2025-05-17T17:47:28Z

idk what the clean/idiomatic way to do that with _regex_arguments is though. tbh i can't stand it and i don't want to learn. rather than just copy+paste everything i'll have to let someone more knowledgeable figure out how to structure/format it

hah! i struggle with that extremly as i want to extend the wpctl completion. not my latest local thing but you will see silly it looks :P

If you know someone please ask them.

…which-pkg-broke dhomepage wording tweaked by dana

last seen in squeeze

_apt-file: add list-indices (wording tweaked by dana) _bug: update bts backends from `reportbug --bts help` output _debsnap: complete -l as --list _deb_architectures: update archs (source: popcon) _losetup: remove "--delete" _rsync: add PROGRESS2 to --info _x_utils: add eventtype "button"

…which-pkg-broke dhomepage tweaked by dana

last seen in squeeze

_apt-file: add list-indices (wording tweaked by dana) _bug: update bts backends from `reportbug --bts help` output _debsnap: complete -l as --list _deb_architectures: update archs (source: popcon) _losetup: remove "--delete" _rsync: add PROGRESS2 to --info _x_utils: add eventtype "button"

okdana · 2025-06-05T06:56:15Z

since there's no end in sight yet for 5.10 testing and i've been merging other minor/new completion stuff, i decided to go ahead with at least the most trivial of these changes. they've been merged as abced20 (new functions), 606967d (removed functions), and 07a50d5 (minor updates)

i may or may not do any of the rest before release. just nervous about breaking existing functionality (and conscious of the fact that i can keep rationalising 'just one more' right up to the end)

crpb added 23 commits April 12, 2025 13:32

Completion/Debian/Command/_apt-file: add list-indices

81670bd

Completion/Debian/Command/_bug

5c61f28

* update bts backends from `reportbug --bts help` output

Completion/Debian/Command/_debsnap: complete _deb_packages avail

49a17b5

Completion/Debian/Command/_dpkg: add missing options

31be8b6

* added -raw-extract/-R, --ctrl-tarfile, --verify/-V, --clear-selections, --predep-package, --assert

Completion/Debian/Command/_madison: add missing options

fde7ca3

* added --url/-u, --noconf, --version * extended --component by non-free-firmware

Completion/Debian/Command/_sbuild

360a533

* fixed: --extra-package * changed behaviour to allow options multiple times for --extra-package, --dpkg-source-opt[s]

Completion/Debian/Command/_schroot

fea6a83

* added --all-source-chroots, --exclude-aliases, --shell/-s --option/-o, --automatic-session, --session-name/-n * extend shell lookup via /etc/shells

Completion/Debian/Type/_deb_architectures

2b02740

* updated archs (source: popcon)

Completion/Debian/Type/_deb_files

d80cfba

* add opt -D (.dsc)

Completion/Linux/Command/_losetup

538040f

* remove "--delete"

Completion/Unix/Command/_fortune

aa66010

* complete databases

Completion/Unix/Command/_libvirt

4b2431f

* console should only work with running machines * add guestinfo to fast opts (w/o --domain)

Completion/Unix/Command/_rsync

66e7d9f

* add PROGRESS2 to --info

Completion/Unix/Command/_smartmontools

289d810

* add json option+arguments * update devicetypes arguments

Completion/Unix/Command/_zfs

22c49e4

* added refreservation to delegatable permissions * fixed scriptname completion to only list filenames

Completion/X/Command/_x_utils

63c7939

* add eventtype "button"

removed Completion/Debian/Command/_wanna-build

5f14fc4

last seen in squeeze

Completion/Debian/Command/_debmany

fd63df5

complete _deb_packages aval

Completion/Debian/Command/_dhomepage

d30ff1c

* NEW (complies to latest upstream version) https://salsa.debian.org/debian/debian-goodies/-/commit/1f9a8a771ba68e791ceb7c4821fbdaac78f4921b

Completion/Debian/Command/_dpkg-info

e2cf8be

* complete _deb_packages avail

Completion/Debian/Command/_which-pkg-broke

313873f

* complete _deb_packages avail

Completion/Debian/Command/_madison: add url-shorthand for table "all"

bd64f6a

okdana added 2 commits May 4, 2025 06:58

fixup: undo corrupted white space, idk what happened

b9a09db

fixup: fix smartctl --json optarg

eae57b1

make optional, remove unnecessary exclusions

okdana added 4 commits May 16, 2025 11:03

fixup: undo corrupted white space, idk what happened

6c46552

fixup: fix smartctl --json optarg

f8fa678

make optional, remove unnecessary exclusions

crpb added 2 commits May 18, 2025 10:28

_apt: source+build-dep _deb_packages source

27fc956

Merge branch 'cb/completions' into migrate-okdana

73d9c5a

okdana pushed a commit to okdana/zsh that referenced this pull request Jun 5, 2025

github zsh-users#131: completion: add debmany, dhomepage, dpkg-info, …

5ea60b1

…which-pkg-broke dhomepage wording tweaked by dana

okdana pushed a commit to okdana/zsh that referenced this pull request Jun 5, 2025

github zsh-users#131: completion: remove wanna-build

9c15ad8

last seen in squeeze

okdana pushed a commit to okdana/zsh that referenced this pull request Jun 5, 2025

github zsh-users#131: completion: add debmany, dhomepage, dpkg-info, …

abced20

…which-pkg-broke dhomepage tweaked by dana

okdana pushed a commit to okdana/zsh that referenced this pull request Jun 5, 2025

github zsh-users#131: completion: remove wanna-build

606967d

last seen in squeeze

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

completions #131

completions #131

Uh oh!

crpb commented Apr 12, 2025

Uh oh!

okdana commented May 4, 2025

Uh oh!

crpb commented May 4, 2025 •

edited

Loading

Uh oh!

okdana commented May 4, 2025

Uh oh!

crpb commented May 4, 2025

Uh oh!

mika commented May 4, 2025

Uh oh!

okdana commented May 4, 2025

Uh oh!

mika commented May 4, 2025

Uh oh!

crpb commented May 16, 2025

Uh oh!

okdana commented May 16, 2025

Uh oh!

crpb commented May 17, 2025

Uh oh!

okdana commented Jun 5, 2025

Uh oh!

Uh oh!

completions #131

Are you sure you want to change the base?

completions #131

Uh oh!

Conversation

crpb commented Apr 12, 2025

Uh oh!

okdana commented May 4, 2025

Uh oh!

crpb commented May 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

okdana commented May 4, 2025

Uh oh!

crpb commented May 4, 2025

Uh oh!

mika commented May 4, 2025

Uh oh!

okdana commented May 4, 2025

Uh oh!

mika commented May 4, 2025

Uh oh!

crpb commented May 16, 2025

Uh oh!

okdana commented May 16, 2025

Uh oh!

crpb commented May 17, 2025

Uh oh!

okdana commented Jun 5, 2025

Uh oh!

Uh oh!

crpb commented May 4, 2025 •

edited

Loading